[FLINK-38846][mysql] Optimize LinkedList processing in handleChange method to reduce complexity#4250
Merged
Conversation
…ethod to reduce complexity
…ethod to reduce complexity
Contributor
|
I'm unclear how the O(n²) time complexity arises—could you elaborate on the specific cause? |
Member
Author
As ticket say, the BinaryLogClient return LinkedList. But MySqlStreamingChangeEventSource handleChange() uses Index-based for loop traversal So the cost is |
ThorneANN
pushed a commit
to ThorneANN/flink-cdc
that referenced
this pull request
Mar 19, 2026
…ethod to reduce complexity (apache#4250)
Mrart
pushed a commit
to Mrart/flink-cdc
that referenced
this pull request
Mar 26, 2026
…ethod to reduce complexity (apache#4250)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This close https://issues.apache.org/jira/browse/FLINK-38846
This pull request optimizes the processing of row events in the MySQL and OceanBase CDC connectors by replacing an index-based loop with an iterator-based loop in the
handleChangemethod. This change improves performance when handlingLinkedListrow collections, reducing time complexity from O(n²) to O(n).